package_is_path: do not check if path exists#1779
Open
StaticRocket wants to merge 1 commit intopypa:mainfrom
Open
package_is_path: do not check if path exists#1779StaticRocket wants to merge 1 commit intopypa:mainfrom
StaticRocket wants to merge 1 commit intopypa:mainfrom
Conversation
Having separators is the real indicator that the user is doing something wrong. We shouldn't unnecessarily error out in the off chance the user has a directory that has the same name as a package in the current working directory. Signed-off-by: Randolph Sapp <rs@ti.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having separators is the real indicator that the user is doing something wrong. We shouldn't unnecessarily error out in the off chance the user has a directory that has the same name as a package in the current working directory.
Thanks for contributing, make sure you address all the checklists (for details on how see development documentation)
pre-commit run --all-files)changelog.d/folderNot entirely sure if this needs a test or documentation update considering it's so small and there aren't many tests for specific functions outlined in the
main.py.Fixes: #1778